From d40742ef71ede64d2acb7ae9a451dc0704a468f4 Mon Sep 17 00:00:00 2001 From: Benjamin Wilson Date: Mon, 15 Jul 2024 09:16:55 -0400 Subject: [PATCH] bug --- src/models/StratumV1Client.ts | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/models/StratumV1Client.ts b/src/models/StratumV1Client.ts index c08a18f..668b46c 100644 --- a/src/models/StratumV1Client.ts +++ b/src/models/StratumV1Client.ts @@ -477,10 +477,10 @@ export class StratumV1Client { const job = this.stratumV1JobsService.getJobById(submission.jobId); - const jobTemplate = this.stratumV1JobsService.getJobTemplateById(job.jobTemplateId); + // a miner may submit a job that doesn't exist anymore if it was removed by a new block notification - if (job == null || jobTemplate == null) { + if (job == null) { const err = new StratumErrorMessage( submission.id, eStratumErrorCode.JobNotFound, @@ -492,6 +492,21 @@ export class StratumV1Client { } return false; } + + const jobTemplate = this.stratumV1JobsService.getJobTemplateById(job.jobTemplateId); + + if (jobTemplate == null) { + const err = new StratumErrorMessage( + submission.id, + eStratumErrorCode.JobNotFound, + 'Job Template not found').response(); + //console.log(err); + const success = await this.write(err); + if (!success) { + return false; + } + return false; + } const updatedJobBlock = job.copyAndUpdateBlock(