From 6442bb45e0030920c76536435f7c6dff821dfc98 Mon Sep 17 00:00:00 2001
From: Georges <g.palauqui@gptechinno.com>
Date: Fri, 23 Feb 2024 18:51:27 +0100
Subject: [PATCH] stratum: set_difficulty should always be a notification (#32)

---
 src/models/StratumV1Client.spec.ts                      | 2 +-
 src/models/stratum-messages/SuggestDifficultyMessage.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/models/StratumV1Client.spec.ts b/src/models/StratumV1Client.spec.ts
index 31b0f1d..d83b505 100644
--- a/src/models/StratumV1Client.spec.ts
+++ b/src/models/StratumV1Client.spec.ts
@@ -202,7 +202,7 @@ describe('StratumV1Client', () => {
         expect(socket.on).toHaveBeenCalled();
         socketEmitter(Buffer.from(MockRecording1.MINING_SUGGEST_DIFFICULTY));
         await new Promise((r) => setTimeout(r, 1));
-        expect(socket.write).toHaveBeenCalledWith(`{"id":4,"method":"mining.set_difficulty","params":[512]}\n`, expect.any(Function));
+        expect(socket.write).toHaveBeenCalledWith(`{"id":null,"method":"mining.set_difficulty","params":[512]}\n`, expect.any(Function));
     });
 
     it('should set difficulty', async () => {
diff --git a/src/models/stratum-messages/SuggestDifficultyMessage.ts b/src/models/stratum-messages/SuggestDifficultyMessage.ts
index 09d78e3..2a1b90c 100644
--- a/src/models/stratum-messages/SuggestDifficultyMessage.ts
+++ b/src/models/stratum-messages/SuggestDifficultyMessage.ts
@@ -31,7 +31,7 @@ export class SuggestDifficulty extends StratumBaseMessage {
 
     public response(difficulty: number) {
         return {
-            id: this.id,
+            id: null,
             method: eResponseMethod.SET_DIFFICULTY,
             params: [difficulty]
         }